[Bugfix] Register VLLM_BATCH_INVARIANT in envs.py to fix spurious unknown env var warning by WindChimeRan · Pull Request #35007 · vllm-project/vllm

WindChimeRan · 2026-02-21T04:33:18Z

Purpose

Register VLLM_BATCH_INVARIANT in envs.py to suppress spurious warning.

VLLM_BATCH_INVARIANT is read via os.getenv() in batch_invariant.py but is never registered in envs.py's environment_variables dict. This causes validate_environ() to emit an "Unknown vLLM environment variable detected" warning every time the feature is used:

WARNING 02-20 23:18:09 [envs.py:1656] Unknown vLLM environment variable detected: VLLM_BATCH_INVARIANT

This PR adds the env var to both the type stub and the registry dict in envs.py.

Test Plan

import os
os.environ["VLLM_BATCH_INVARIANT"] = "1"

from vllm import LLM, SamplingParams

llm = LLM(
    model="Qwen/Qwen3-0.6B",
    max_model_len=128,
    attention_config={"backend": "FLASH_ATTN"},
)
print(llm.generate(["Hello"], SamplingParams(temperature=0, max_tokens=5))[0].outputs[0].text)

Verify no "Unknown vLLM environment variable" warning is emitted.

Test Result

Before: warning is emitted on every invocation with VLLM_BATCH_INVARIANT set.

WARNING 02-20 23:18:09 [envs.py:1656] Unknown vLLM environment variable detected: VLLM_BATCH_INVARIANT

After: no warning.

Essential Elements of an Effective PR Description Checklist

The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
The test plan, such as providing test command.
The test results, such as pasting the results comparison before and after, or e2e results
(Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
(Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Ranran <1012869439@qq.com>

dosubot · 2026-02-21T04:33:26Z

Related Documentation

Checked 0 published document(s) in 1 knowledge base(s). No updates required.

^{How did I do? Any feedback?}

gemini-code-assist

Code Review

The pull request correctly registers the VLLM_BATCH_INVARIANT environment variable in vllm/envs.py to suppress the 'Unknown vLLM environment variable' warning. This is a necessary step for maintaining a clean log output when this feature is used. However, the implementation of the boolean conversion for this variable is less robust than the one it replaces in batch_invariant.py and could lead to a crash if a non-integer value (like 'true') is provided. Additionally, there is now duplicated logic for reading this environment variable between envs.py and batch_invariant.py, which should ideally be consolidated if circular dependencies can be avoided.

gemini-code-assist · 2026-02-21T04:34:36Z

+    "VLLM_BATCH_INVARIANT": lambda: bool(
+        int(os.getenv("VLLM_BATCH_INVARIANT", "0"))
+    ),


The current implementation using int() will raise a ValueError and crash the application if the environment variable is set to a non-integer value such as "true" or "false". This is a regression in robustness compared to the original implementation in batch_invariant.py which handled this error gracefully. It is recommended to use a more robust parsing pattern consistent with other variables in this file (e.g., VLLM_USE_PRECOMPILED).

Suggested change

"VLLM_BATCH_INVARIANT": lambda: bool(

int(os.getenv("VLLM_BATCH_INVARIANT", "0"))

),

"VLLM_BATCH_INVARIANT": lambda: os.getenv("VLLM_BATCH_INVARIANT", "0")

.strip()

.lower()

in ("1", "true"),

I think this is overcomplicating things. my style is consistent with other envs. So it should be fine.

mergify · 2026-02-21T04:38:08Z

Hi @WindChimeRan, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

Signed-off-by: Ranran <1012869439@qq.com>

yewentao256

Thanks for the work! The idea looks good

Please update the logic in _read_vllm_batch_invariant and related usage

Signed-off-by: Ranran <1012869439@qq.com>

Signed-off-by: ran <hzz5361@psu.edu>

yewentao256

Please solve the pre-commit issue so that we can land this pr

mergify · 2026-03-23T12:55:39Z

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @WindChimeRan.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

…variant-env Signed-off-by: ran <hzz5361@psu.edu>

WindChimeRan · 2026-03-23T21:26:20Z

@yewentao256 All green!

…nown env var warning (vllm-project#35007) Signed-off-by: Ranran <1012869439@qq.com> Signed-off-by: Ranran <hzz5361@psu.edu> Signed-off-by: ran <hzz5361@psu.edu> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>

…nown env var warning (vllm-project#35007) Signed-off-by: Ranran <1012869439@qq.com> Signed-off-by: Ranran <hzz5361@psu.edu> Signed-off-by: ran <hzz5361@psu.edu> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>

Update to match upstream changes from commit dc6908a (vllm-project#35007): - Remove import of vllm_is_batch_invariant - Change vllm_is_batch_invariant() to envs.VLLM_BATCH_INVARIANT This fixes the inconsistency where origin/main uses the envs approach but our branch was still using the old function call. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: khairulkabir1661 <khairulkabir1661@users.noreply.github.com>

…nown env var warning (vllm-project#35007) Signed-off-by: Ranran <1012869439@qq.com> Signed-off-by: Ranran <hzz5361@psu.edu> Signed-off-by: ran <hzz5361@psu.edu> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>

…nown env var warning (vllm-project#35007) Signed-off-by: Ranran <1012869439@qq.com> Signed-off-by: Ranran <hzz5361@psu.edu> Signed-off-by: ran <hzz5361@psu.edu> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>

…nown env var warning (vllm-project#35007) Signed-off-by: Ranran <1012869439@qq.com> Signed-off-by: Ranran <hzz5361@psu.edu> Signed-off-by: ran <hzz5361@psu.edu> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com> Signed-off-by: Vinay Damodaran <vrdn@hey.com>

…nown env var warning (vllm-project#35007) Signed-off-by: Ranran <1012869439@qq.com> Signed-off-by: Ranran <hzz5361@psu.edu> Signed-off-by: ran <hzz5361@psu.edu> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com> Signed-off-by: EricccYang <yangyang4991@gmail.com>

…nown env var warning (vllm-project#35007) Signed-off-by: Ranran <1012869439@qq.com> Signed-off-by: Ranran <hzz5361@psu.edu> Signed-off-by: ran <hzz5361@psu.edu> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>

…nown env var warning (vllm-project#35007) Signed-off-by: Ranran <1012869439@qq.com> Signed-off-by: Ranran <hzz5361@psu.edu> Signed-off-by: ran <hzz5361@psu.edu> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com> Signed-off-by: rishitdholakia13 <rishit+github@cohere.com>

…nown env var warning (vllm-project#35007) Signed-off-by: Ranran <1012869439@qq.com> Signed-off-by: Ranran <hzz5361@psu.edu> Signed-off-by: ran <hzz5361@psu.edu> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com> Signed-off-by: Rishi Puri <riship@nvidia.com>

…nown env var warning (vllm-project#35007) Signed-off-by: Ranran <1012869439@qq.com> Signed-off-by: Ranran <hzz5361@psu.edu> Signed-off-by: ran <hzz5361@psu.edu> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>

similar fix to my upstream PR: vllm-project/vllm#35007 * register all env vars in a vllm way * dedicated `envs.py` * update relevant unit tests ### The problem **before**: unregistered envs warning <img width="1168" height="259" alt="image" src="https://github.com/user-attachments/assets/e447e7cc-d3bc-446e-9f5f-22850223f62b" /> **after**: the warning disappeared. --------- Signed-off-by: ran <hzz5361@psu.edu> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix batch invariant warning

3d3c556

Signed-off-by: Ranran <1012869439@qq.com>

mergify bot added the bug Something isn't working label Feb 21, 2026

gemini-code-assist bot reviewed Feb 21, 2026

View reviewed changes

WindChimeRan and others added 6 commits February 20, 2026 23:44

add pre-commit

0a0ea10

Signed-off-by: Ranran <1012869439@qq.com>

Merge branch 'main' into fix/register-batch-invariant-env

f42bf0e

Merge branch 'main' into fix/register-batch-invariant-env

aa879f6

Merge branch 'main' into fix/register-batch-invariant-env

6e3d53f

Merge branch 'main' into fix/register-batch-invariant-env

899d1e8

Merge branch 'main' into fix/register-batch-invariant-env

98d2996

WindChimeRan mentioned this pull request Feb 27, 2026

[Feature]: batch invariance for A100 #32658

Open

1 task

yewentao256 reviewed Feb 27, 2026

View reviewed changes

WindChimeRan and others added 2 commits March 1, 2026 14:06

Merge branch 'main' into fix/register-batch-invariant-env

bb3e4b2

update all env var consumers

48eeee6

Signed-off-by: Ranran <1012869439@qq.com>

WindChimeRan requested review from LucasWilkinson, MatthewBonanni, ProExpertProg, WoosukKwon, hmellor, houseroad, jeejeelee, mgoin, pavanimajety, robertgshaw2-redhat, tdoublep, tlrmchlsmth and youkaichao as code owners March 1, 2026 20:19

mergify bot added nvidia v1 labels Mar 1, 2026

fix fp8 utils merging conflict

e9da71a

Signed-off-by: ran <hzz5361@psu.edu>

auto-merge was automatically disabled March 22, 2026 22:48
Head branch was pushed to by a user without write access

yewentao256 reviewed Mar 23, 2026

View reviewed changes

mergify bot added the needs-rebase label Mar 23, 2026

Merge remote-tracking branch 'origin/main' into fix/register-batch-in…

0843198

…variant-env Signed-off-by: ran <hzz5361@psu.edu>

WindChimeRan force-pushed the fix/register-batch-invariant-env branch from 03ab562 to 0843198 Compare March 23, 2026 19:59

mergify bot removed the needs-rebase label Mar 23, 2026

WindChimeRan requested a review from yewentao256 March 23, 2026 21:26

yewentao256 approved these changes Mar 23, 2026

View reviewed changes

yewentao256 merged commit dc6908a into vllm-project:main Mar 23, 2026
91 checks passed

github-project-automation bot moved this from Ready to Done in NVIDIA Mar 23, 2026

leo-pony mentioned this pull request Apr 3, 2026

[CI] Main2main upgrade to 0324 vllm-project/vllm-ascend#7787

Merged

WindChimeRan mentioned this pull request Apr 9, 2026

refactor env register in a vllm way vllm-project/vllm-metal#256

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Bugfix] Register VLLM_BATCH_INVARIANT in envs.py to fix spurious unknown env var warning#35007

[Bugfix] Register VLLM_BATCH_INVARIANT in envs.py to fix spurious unknown env var warning#35007
yewentao256 merged 32 commits intovllm-project:mainfrom
WindChimeRan:fix/register-batch-invariant-env

WindChimeRan commented Feb 21, 2026 •

edited by github-actions bot

Loading

Uh oh!

dosubot bot commented Feb 21, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Feb 21, 2026

Uh oh!

WindChimeRan Feb 21, 2026

Uh oh!

mergify bot commented Feb 21, 2026

Uh oh!

yewentao256 left a comment

Uh oh!

yewentao256 left a comment

Uh oh!

mergify bot commented Mar 23, 2026

Uh oh!

WindChimeRan commented Mar 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-    "VLLM_BATCH_INVARIANT": lambda: bool(
-        int(os.getenv("VLLM_BATCH_INVARIANT", "0"))
-    ),
+    "VLLM_BATCH_INVARIANT": lambda: os.getenv("VLLM_BATCH_INVARIANT", "0")
+    .strip()
+    .lower()
+    in ("1", "true"),

Uh oh!

Conversation

WindChimeRan commented Feb 21, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Test Plan

Test Result

Uh oh!

dosubot bot commented Feb 21, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

WindChimeRan Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Feb 21, 2026

Uh oh!

yewentao256 left a comment

Choose a reason for hiding this comment

Uh oh!

yewentao256 left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Mar 23, 2026

Uh oh!

WindChimeRan commented Mar 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

WindChimeRan commented Feb 21, 2026 •

edited by github-actions bot

Loading